Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: bump Pebble to the updated Category API #133643

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

RaduBerinde
Copy link
Member

@RaduBerinde RaduBerinde commented Oct 29, 2024

Changes:

  • 71bb6ba2 sstable: make Category an enum

Release note: none.
Fixes #133507

Copy link

blathers-crl bot commented Oct 29, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Changes:

 * [`71bb6ba2`](cockroachdb/pebble@71bb6ba2) sstable: make Category an enum

Release note: none.
Epic: none.
@RaduBerinde RaduBerinde requested a review from jbowens November 4, 2024 02:25
@RaduBerinde RaduBerinde changed the title storage: use the updated Category API storage: bump Pebble to the updated Category API Nov 4, 2024
@RaduBerinde RaduBerinde marked this pull request as ready for review November 4, 2024 02:25
@RaduBerinde RaduBerinde requested review from a team as code owners November 4, 2024 02:25
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)

@RaduBerinde
Copy link
Member Author

TFTR!

bors r+

@craig craig bot merged commit aae0a58 into cockroachdb:master Nov 5, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: pebble category metrics are initialized too late
3 participants