Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cockroachdb: speed up multi-register test and fix split nemesis #20

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

nvanbenschoten
Copy link
Member

This is needed for cockroachdb/cockroach#36616.

This helps reduce the time of runs to a more reasonable limit.
Since introducing Range merges in CockroachDB v2.1, manual Range splits
have only been allowed if the merge queue is disabled first. This commit
disables the merge queue when the split-nemesis is in use, preventing
errors like the following:
```
INFO [2019-04-17 19:32:45,072] jepsen nemesis - jepsen.util :nemesis	:info	["splits" :split]	nil	indeterminate: ERROR: splits would be immediately discarded by merge queue; disable the merge queue first by running 'SET CLUSTER SETTING kv.range_merge.queue_enabled = false'
```
@@ -110,12 +110,12 @@
{:name "multi-register"
:client {:client (MultiAtomicClient. (atom false) nil)
:during (independent/concurrent-generator
(count (:nodes opts))
3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this 3 instead of the size of the cluster like it was before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing the concurrency sped up the test. Setting this to the size of the cluster was somewhat arbitrary. Tests like comments do that but tests like register set it to a constant value.

@nvanbenschoten nvanbenschoten merged commit c711afd into tc-nightly Apr 17, 2019
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/multiRegisterSpeed branch April 17, 2019 20:16
aliher1911 pushed a commit to aliher1911/jepsen that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants