roachtest: add new multi-register jepsen test #36616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
20 minutes per nemesis, right? And the difference is just that the multi-linearizability checker after each run is slow? FYI the other tests are all about half that.
Let's keep it three groups: two groups of three and one group of two, with multiregister in the group of two (with a comment that it takes twice as long as the others).
This PR adds the new Jepsen test introduced in: cockroachdb/jepsen#19 The test takes 19-21 minutes per run. I think that means it should go in its own "group". Maybe there's a better group for it to go in. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/jepsenNew
branch
from
9211365 to
d8aa9a7
Compare
|
Ok, this should be ready to go once cockroachdb/jepsen#20 is merged. I've run through it a few times to verify that it is sufficiently stable to be run nightly.
Done. |
|
bors r=bdarnell |
craig bot
pushed a commit
that referenced
this pull request
Apr 17, 2019
36616: roachtest: add new multi-register jepsen test r=bdarnell a=nvanbenschoten This PR adds the new Jepsen test introduced in: cockroachdb/jepsen#19 The test takes 19-21 minutes per run. I think that means it should go in its own "group". Maybe there's a better group for it to go in. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new Jepsen test introduced in: cockroachdb/jepsen#19
The test takes 19-21 minutes per run. I think that means it should go in its own "group". Maybe there's a better group for it to go in.
Release note: None