Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ON UPDATE expressions #12035

Merged
merged 6 commits into from
Nov 3, 2021
Merged

ON UPDATE expressions #12035

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e16a68
ON UPDATE expressions
ericharmeling Oct 20, 2021
d85b583
link fix
ericharmeling Oct 21, 2021
a8ce763
Added ON UPDATE to computed column considerations
ericharmeling Oct 26, 2021
3a9c18b
rafiss feedback
ericharmeling Oct 28, 2021
f564e2b
pawalt feedback
ericharmeling Nov 2, 2021
4da219e
stbof feedback
ericharmeling Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion v21.2/computed-columns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Computed columns:
- Cannot be used to generate other computed columns.
- Cannot reference a [foreign key](foreign-key.html).
- Behave like any other column, with the exception that they cannot be written to directly.
- Are mutually exclusive with [`DEFAULT`](default-value.html).
- Are mutually exclusive with [`DEFAULT` constraints](default-value.html) and [`ON UPDATE` expressions](add-column.html#on-update-expressions).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: DEFAULT isn't really a "constraint" -- maybe say DEFAULT expressions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or DEFAULT qualifications?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT isn't really a "constraint"

Hmm... we document DEFAULT as a column constraint all over our docs (see the Default Value Constraint and Constraints pages).

I've updated this particular instance to use "DEFAULT expressions", but, if you think the other docs are incorrect/misleading, I can file a new issue to update how we document DEFAULT in a separate PR. Maybe we just fold the entire "Default Value Constraint" page into a subsection of ADD COLUMN (like we've done here with ON UPDATE).


Virtual computed columns:

Expand Down