ON UPDATE expressions #12035

ericharmeling · 2021-10-21T17:16:46Z

Fixes #11441.
Related to #11028.

cockroach-teamcity · 2021-10-21T17:16:54Z

This change is

github-actions · 2021-10-21T17:17:20Z

Files changed:

v20.2/add-column.md
v21.1/add-column.md
v21.1/default-value.md
v21.2/add-column.md
v21.2/alter-column.md
v21.2/computed-columns.md
v21.2/create-table.md

netlify · 2021-10-21T17:58:36Z

✔️ Netlify Preview

🔨 Explore the source changes: 4da219e

🔍 Inspect the deploy log: https://app.netlify.com/sites/cockroachdb-docs/deploys/61827552846a1b000851a002

😎 Browse the preview: https://deploy-preview-12035--cockroachdb-docs.netlify.app/docs/v21.2/add-column

ericharmeling · 2021-10-21T18:03:04Z

@mgartner Adding you for eng review, as original author of cockroachdb/cockroach#69091 is no longer with us.

Feel free to request a reassign!

rafiss · 2021-10-25T21:09:04Z

one thought: in the computed columns page, we should also mention that computed columns are mutually exclusive with ON UPDATE. (this consideration is already noted for DEFAULT)

https://www.cockroachlabs.com/docs/stable/computed-columns.html#considerations

ericharmeling · 2021-10-26T15:06:08Z

@rmloveland

ericharmeling · 2021-10-26T16:47:19Z

in the computed columns page, we should also mention that computed columns are mutually exclusive with ON UPDATE. (this consideration is already noted for DEFAULT)

Done!

Fixes #11214 Fixes #11454 Fixes #11212 Depends on a link that will exist once we merge #12035

Fixes #11214 Fixes #11454 Fixes #11212 Links to ON UPDATE content that will exist once we merge #12035

rafiss

examples looks great! just had comments about how DEFAULT and ON UPDATE should probably be categorized the same as each other

rafiss · 2021-10-27T19:12:45Z

v21.2/computed-columns.md

@@ -21,7 +21,7 @@ Computed columns:
 - Cannot be used to generate other computed columns.
 - Cannot reference a [foreign key](foreign-key.html).
 - Behave like any other column, with the exception that they cannot be written to directly.
- Are mutually exclusive with [`DEFAULT`](default-value.html).
+- Are mutually exclusive with [`DEFAULT` constraints](default-value.html) and [`ON UPDATE` expressions](add-column.html#on-update-expressions).


nit: DEFAULT isn't really a "constraint" -- maybe say DEFAULT expressions

or DEFAULT qualifications?

DEFAULT isn't really a "constraint"

Hmm... we document DEFAULT as a column constraint all over our docs (see the Default Value Constraint and Constraints pages).

I've updated this particular instance to use "DEFAULT expressions", but, if you think the other docs are incorrect/misleading, I can file a new issue to update how we document DEFAULT in a separate PR. Maybe we just fold the entire "Default Value Constraint" page into a subsection of ADD COLUMN (like we've done here with ON UPDATE).

rafiss · 2021-10-27T19:14:22Z

v21.2/add-column.md

+- [Column-level constraints](constraints.html)
+- [Collations](collate.html)
+- [Column family assignments](column-families.html)
+- <span class="version-tag">New in v21.2</span>: [`ON UPDATE` expressions](#on-update-expressions)


similar to my other comment, i don't thing DEFAULT should be included under constraints. instead, DEFAULT should be documented as basically identically to ON UPDATE

Done

(but see my comment below)

mgartner

LGTM

ericharmeling

TFTR!

ericharmeling · 2021-10-28T15:06:19Z

v21.2/computed-columns.md

@@ -21,7 +21,7 @@ Computed columns:
 - Cannot be used to generate other computed columns.
 - Cannot reference a [foreign key](foreign-key.html).
 - Behave like any other column, with the exception that they cannot be written to directly.
- Are mutually exclusive with [`DEFAULT`](default-value.html).
+- Are mutually exclusive with [`DEFAULT` constraints](default-value.html) and [`ON UPDATE` expressions](add-column.html#on-update-expressions).


DEFAULT isn't really a "constraint"

Hmm... we document DEFAULT as a column constraint all over our docs (see the Default Value Constraint and Constraints pages).

I've updated this particular instance to use "DEFAULT expressions", but, if you think the other docs are incorrect/misleading, I can file a new issue to update how we document DEFAULT in a separate PR. Maybe we just fold the entire "Default Value Constraint" page into a subsection of ADD COLUMN (like we've done here with ON UPDATE).

ericharmeling · 2021-10-28T15:11:44Z

v21.2/add-column.md

+Note the following limitations of `ON UPDATE` expressions:
+
+- You cannot add a [foreign key constraint](foreign-key.html) and an `ON UPDATE` expression to the same column.
+- Values populated by [`DEFAULT` constraints](default-value.html) do not trigger an `ON UPDATE` change.


Values populated by DEFAULT constraints do not trigger an ON UPDATE change.

Updated this line

ericharmeling · 2021-10-28T15:13:22Z

v21.2/add-column.md

+- [Column-level constraints](constraints.html)
+- [Collations](collate.html)
+- [Column family assignments](column-families.html)
+- <span class="version-tag">New in v21.2</span>: [`ON UPDATE` expressions](#on-update-expressions)


Done

(but see my comment below)

Fixes #11214 Fixes #11454 Fixes #11212 Links to ON UPDATE content that will exist once we merge #12035

pawalt · 2021-10-28T22:20:47Z

This looks great! My only note is that ON UPDATE expressions have some behavior regarding when they execute that might be surprising if coming from MySQL ON UPDATE. Probably worth documenting:
https://github.com/cockroachdb/cockroach/blob/master/docs/RFCS/20210722_on_update_and_row_rehoming.md#when-does-on-update-execute

It also may be worth noting that ON UPDATE expressions are closest to DEFAULT in terms of what kinds of expressions they allow (they allow context-dependent expressions but not expressions that reference other columns). For ex. current_timestamp() is allowed.

Fixes #11214 Fixes #11454 Fixes #11212 Links to ON UPDATE content that will exist once we merge #12035

ericharmeling · 2021-11-02T20:47:19Z

@pawalt

Thanks for taking the time to look over this! I've rewritten the "ON UPDATE expressions" section, following your feedback. I am a bit uncertain about the ON UPDATE CASCADE case - could you verify that what I've written is correct?

pawalt · 2021-11-02T22:09:17Z

@ericharmeling LGTM!

ghost · 2021-11-02T22:48:15Z

v21.2/add-column.md

+- [`DEFAULT` expressions](default-value.html)
+- <span class="version-tag">New in v21.2</span>: [`ON UPDATE` expressions](#on-update-expressions)
+
+### ON UPDATE expressions


Suggested change

### ON UPDATE expressions

### `ON UPDATE` expressions

ghost

See suggestion for formatting in heading.

Fixes #11214 Fixes #11454 Fixes #11212 Links to ON UPDATE content that will exist once we merge #12035

Fixes #11214 Fixes #11454 Fixes #11212 Also links to new ON UPDATE content that was added in #12035

ON UPDATE expressions

9e16a68

link fix

d85b583

ericharmeling requested a review from mgartner October 21, 2021 18:00

Added ON UPDATE to computed column considerations

a8ce763

rmloveland added a commit that referenced this pull request Oct 26, 2021

Add docs for auto-rehoming of RBR tables

a14ffc3

Fixes #11214 Fixes #11454 Fixes #11212 Depends on a link that will exist once we merge #12035

rmloveland mentioned this pull request Oct 26, 2021

Add docs for auto-rehoming of RBR tables #12081

Merged

rmloveland added a commit that referenced this pull request Oct 26, 2021

Add docs for auto-rehoming of RBR tables

89c924f

Fixes #11214 Fixes #11454 Fixes #11212 Links to ON UPDATE content that will exist once we merge #12035

rafiss requested changes Oct 27, 2021

View reviewed changes

mgartner approved these changes Oct 28, 2021

View reviewed changes

rafiss feedback

3a9c18b

ericharmeling commented Oct 28, 2021

View reviewed changes

ericharmeling requested a review from rafiss October 28, 2021 15:36

rmloveland added a commit that referenced this pull request Oct 28, 2021

Add docs for auto-rehoming of RBR tables

09808d0

Fixes #11214 Fixes #11454 Fixes #11212 Links to ON UPDATE content that will exist once we merge #12035

ericharmeling mentioned this pull request Oct 28, 2021

Added example ON UPDATE TTL script #12114

Merged

rmloveland added a commit that referenced this pull request Nov 1, 2021

Add docs for auto-rehoming of RBR tables

db7d6ba

Fixes #11214 Fixes #11454 Fixes #11212 Links to ON UPDATE content that will exist once we merge #12035

pawalt feedback

f564e2b

ericharmeling requested a review from a user November 2, 2021 22:46

ghost reviewed Nov 2, 2021

View reviewed changes

ghost approved these changes Nov 2, 2021

View reviewed changes

stbof feedback

4da219e

ericharmeling merged commit 4f44bfc into master Nov 3, 2021

ericharmeling deleted the on-update branch November 3, 2021 12:13

rmloveland added a commit that referenced this pull request Nov 4, 2021

Add docs for auto-rehoming of RBR tables

e895aa8

Fixes #11214 Fixes #11454 Fixes #11212 Links to ON UPDATE content that will exist once we merge #12035

rmloveland added a commit that referenced this pull request Nov 8, 2021

Add docs for auto-rehoming of RBR tables

fd0abcd

Fixes #11214 Fixes #11454 Fixes #11212 Also links to new ON UPDATE content that was added in #12035

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ON UPDATE expressions #12035

ON UPDATE expressions #12035

ericharmeling commented Oct 21, 2021

cockroach-teamcity commented Oct 21, 2021

github-actions bot commented Oct 21, 2021 •

edited

Loading

netlify bot commented Oct 21, 2021 •

edited

Loading

ericharmeling commented Oct 21, 2021

rafiss commented Oct 25, 2021

ericharmeling commented Oct 26, 2021

ericharmeling commented Oct 26, 2021

rafiss left a comment

rafiss Oct 27, 2021

mgartner Oct 28, 2021

ericharmeling Oct 28, 2021

rafiss Oct 27, 2021

ericharmeling Oct 28, 2021

mgartner left a comment

ericharmeling left a comment

ericharmeling Oct 28, 2021

ericharmeling Oct 28, 2021

ericharmeling Oct 28, 2021

pawalt commented Oct 28, 2021

ericharmeling commented Nov 2, 2021

pawalt commented Nov 2, 2021

ghost Nov 2, 2021

ericharmeling Nov 3, 2021

ghost left a comment

ON UPDATE expressions #12035

ON UPDATE expressions #12035

Conversation

ericharmeling commented Oct 21, 2021

cockroach-teamcity commented Oct 21, 2021

github-actions bot commented Oct 21, 2021 • edited Loading

netlify bot commented Oct 21, 2021 • edited Loading

ericharmeling commented Oct 21, 2021

rafiss commented Oct 25, 2021

ericharmeling commented Oct 26, 2021

ericharmeling commented Oct 26, 2021

rafiss left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgartner left a comment

Choose a reason for hiding this comment

ericharmeling left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pawalt commented Oct 28, 2021

ericharmeling commented Nov 2, 2021

pawalt commented Nov 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2021 •

edited

Loading

netlify bot commented Oct 21, 2021 •

edited

Loading