Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: skip flaky distsql_automatic_stats for now #99993

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Mar 29, 2023

execbuilder: remove redundant auto stats table overrides

This commit removes table settings overrides of the auto stats
collection in several places. This is unnecessary given that we
explicitly disable the auto stats collection for the whole cluster in
the logic tests.

Release note: None

logictest: skip flaky distsql_automatic_stats for now

We've seen this file become more flaky recently, so let's skip it for
now.

Informs: #99751.

Release note: None

This commit removes table settings overrides of the auto stats
collection in several places. This is unnecessary given that we
explicitly disable the auto stats collection for the whole cluster in
the logic tests.

Release note: None
We've seen this file become more flaky recently, so let's skip it for
now.

Release note: None
@yuzefovich yuzefovich added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Mar 29, 2023
@yuzefovich yuzefovich requested review from michae2 and a team March 29, 2023 22:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@knz
Copy link
Contributor

knz commented Mar 29, 2023

bors r+ p=99 single on

@craig
Copy link
Contributor

craig bot commented Mar 29, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Mar 29, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-99993 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100002/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@yuzefovich yuzefovich deleted the skip-stats-tests branch March 29, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants