-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: flake with distsql_automatic_stats #99751
Comments
I just hit it quickly when trying to repro #99753. I used In this case the machine is overloaded, so |
99993: logictest: skip flaky distsql_automatic_stats for now r=knz a=yuzefovich **execbuilder: remove redundant auto stats table overrides** This commit removes table settings overrides of the auto stats collection in several places. This is unnecessary given that we explicitly disable the auto stats collection for the whole cluster in the logic tests. Release note: None **logictest: skip flaky distsql_automatic_stats for now** We've seen this file become more flaky recently, so let's skip it for now. Informs: #99751. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Now that automatic stats are disabled for system tables in logic tests, `distsql_automatic_stats` was opening the floodgates with its first `SET CLUSTER SETTING sql.stats.automatic_collection.enabled = true`. With this enabled, the automatic stats refresher was executing `CREATE STATISTICS` for every system table, one at a time, often taking longer than the 45s logic test retry limit to get to the user-defined table we really care about. Instead of using the cluster setting, change `distsql_automatic_stats` to use the per-table setting. Fixes: cockroachdb#99751 Epic: None Release note: None
100246: sql: deflake distsql_automatic_stats logic test r=rytaft,yuzefovich a=michae2 **sql: fix formatting of CREATE TABLE AS with storage parameters** We were placing the storage parameters in the wrong place when formatting `CREATE TABLE AS` statements. Fixes: #100243 Epic: None Release note: None **sql: deflake distsql_automatic_stats logic test** Now that automatic stats are disabled for system tables in logic tests, `distsql_automatic_stats` was opening the floodgates with its first `SET CLUSTER SETTING sql.stats.automatic_collection.enabled = true`. With this enabled, the automatic stats refresher was executing `CREATE STATISTICS` for every system table, one at a time, often taking longer than the 45s logic test retry limit to get to the user-defined table we really care about. Instead of using the cluster setting, change `distsql_automatic_stats` to use the per-table setting. Fixes: #99751 Epic: None Release note: None 100311: opt: prohibit hash-sharded index syntactic sugar in test catalog r=mgartner a=mgartner The test catalog now panics when trying to build a hash-sharded index instead of silently ignoring the `USING HASH` clause. This prevents writing tests that incorrectly assume that `USING HASH` works as expected in the test catalog. One test with `USING HASH` has been updated. Fixes #99129 Release note: None Co-authored-by: Michael Erickson <[email protected]> Co-authored-by: Marcus Gartner <[email protected]>
Now that automatic stats are disabled for system tables in logic tests, `distsql_automatic_stats` was opening the floodgates with its first `SET CLUSTER SETTING sql.stats.automatic_collection.enabled = true`. With this enabled, the automatic stats refresher was executing `CREATE STATISTICS` for every system table, one at a time, often taking longer than the 45s logic test retry limit to get to the user-defined table we really care about. Instead of using the cluster setting, change `distsql_automatic_stats` to use the per-table setting. Fixes: cockroachdb#99751 Epic: None Release note: None
Seen on this CI run on staging.
Jira issue: CRDB-26052
The text was updated successfully, but these errors were encountered: