Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: roachtest: added connection timeout to loq recovery ops #99634

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 27, 2023

Backport 1/1 commits from #98851 on behalf of @aliher1911.

/cc @cockroachdb/release


When working with cluster that failed recovery, db connections could get stuck indefinitely preventing test completion. This is caused by driver ignoring context cancellation when attempting to establish connection.
This commit adds a connect timeout option to the driver to prevent this behaviour.

Epic: none

Release note: None

Fixes #98639


Release justification:

When working with cluster that failed recovery, db connections
could get stuck indefinitely preventing test completion. This is
caused by driver ignoring context cancellation when attempting to
establish connection.
This commit adds a connect timeout option to the driver to prevent
this behaviour.

Epic: none

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 27, 2023 08:11
@blathers-crl blathers-crl bot requested review from herkolategan and removed request for a team March 27, 2023 08:11
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-98851 branch from 186218e to ae66106 Compare March 27, 2023 08:11
@blathers-crl blathers-crl bot requested a review from smg260 March 27, 2023 08:11
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-98851 branch from cc31ed7 to 67c3ff0 Compare March 27, 2023 08:11
@blathers-crl blathers-crl bot requested review from msbutler and tbg March 27, 2023 08:11
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 27, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 27, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aliher1911 aliher1911 merged commit e6f636a into release-23.1 Mar 29, 2023
@aliher1911 aliher1911 deleted the blathers/backport-release-23.1-98851 branch March 29, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants