roachtest: added connection timeout to loq recovery ops #98851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliher1911
requested review from
herkolategan and
smg260
and removed request for
a team
|
This change is |
aliher1911
force-pushed
the
deflake_loq_roachtest
branch
from
966ee6e to
05ef750
Compare
tbg
approved these changes
Mar 23, 2023
When working with cluster that failed recovery, db connections could get stuck indefinitely preventing test completion. This is caused by driver ignoring context cancellation when attempting to establish connection. This commit adds a connect timeout option to the driver to prevent this behaviour. Epic: none Release note: None
aliher1911
force-pushed
the
deflake_loq_roachtest
branch
from
05ef750 to
bba0750
Compare
|
bors r=tbg |
|
Build succeeded: |
|
We'll need a 23.1 backport as well, see #99529. blathers backport 23.1 |
|
blathers backport 22.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from bba0750 to blathers/backport-release-22.2-98851: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with cluster that failed recovery, db connections could get stuck indefinitely preventing test completion. This is caused by driver ignoring context cancellation when attempting to establish connection.
This commit adds a connect timeout option to the driver to prevent this behaviour.
Epic: none
Release note: None
Fixes #98639