Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql_test: re-skip TestShowTraceReplica #98615

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

msirek
Copy link
Contributor

@msirek msirek commented Mar 14, 2023

TestShowTraceReplica wasn't failing under stress, but failed in TeamCity
once enabled. This re-skips the test until it can be reliably reproduced
and debugged.

Informs #98598

Release note: None

TestShowTraceReplica wasn't failing under stress, but failed in TeamCity
once enabled. This re-skips the test until it can be reliably reproduced
and debugged.

Fixes cockroachdb#98442

Release note: None
@msirek msirek requested review from mgartner and a team March 14, 2023 19:35
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msirek msirek requested a review from knz March 14, 2023 23:31
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you want to write "fixes 98598" in the pr description? this will cause that issue to be closed.

Copy link
Contributor Author

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you want to write "fixes 98598" in the pr description? this will cause that issue to be closed.

Changed to "Informs".
TFTR!
bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mgartner)

@craig
Copy link
Contributor

craig bot commented Mar 15, 2023

Build succeeded:

@craig craig bot merged commit 1bb2934 into cockroachdb:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants