-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: unskip TestShowTraceReplica #34213
Comments
SHA: https://github.com/cockroachdb/cockroach/commits/295b6ae3142518f04a5771c79ce171043697ee1f Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1107708&tab=buildLog
|
I'm looking at this test and I don't understand how it ever worked. It seems to assert which nodes are being touched for operations, but it doesn't seem to wait for the zone constraints it enacts to actually come into effect. Am I missing something here? |
Did you notice that it runs the assertions in a SucceedsSoon? |
SHA: https://github.com/cockroachdb/cockroach/commits/dc2fbcdc0dccb8cc676fc67370375bab36b3cff0 Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1110240&tab=buildLog
|
SHA: https://github.com/cockroachdb/cockroach/commits/dc2fbcdc0dccb8cc676fc67370375bab36b3cff0 Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1110826&tab=buildLog
|
SHA: https://github.com/cockroachdb/cockroach/commits/8cbeb534432b81c57564956ed7d645b854b426be Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1111412&tab=buildLog
|
SHA: https://github.com/cockroachdb/cockroach/commits/9f084ad576e85756c5c5a7e41335d9aa2d3eee30 Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1112213&tab=buildLog
|
SHA: https://github.com/cockroachdb/cockroach/commits/9f084ad576e85756c5c5a7e41335d9aa2d3eee30 Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1112491&tab=buildLog
|
Bisected to 3fe74e1 (confirmed manually). |
Thanks 🙈 @petermattis can you check if there's an obvious cause in 3fe74e1? |
This test is interesting because it configures a replication factor of 1. Perhaps the more restrictive logic for when rebalancing can occur is preventing rebalancing of a single-replica range. |
Good point. This is fairly flaky, so if you can't investigate today or tomorrow let me know and I'll skip the test for now (or do that yourself). |
Please skip for now. I probably won't get to it today or tomorrow. |
See cockroachdb#34213 (comment). Release note: None
34297: storage: skip TestShowTraceReplica r=petermattis a=tbg See #34213 (comment). Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
We've re-skipped this test in #98615. There's some useful information on how to reproduce this in #98598 (comment). |
The latest failure we observed seems to indicate that we performed the read not where we thought we would. This seems like KV / replication issue, so I'm putting it on the KV project. |
cc @cockroachdb/replication |
cc @cockroachdb/replication |
SHA: https://github.com/cockroachdb/cockroach/commits/295b6ae3142518f04a5771c79ce171043697ee1f
Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1107430&tab=buildLog
Jira issue: CRDB-4661
Epic CRDB-27234
The text was updated successfully, but these errors were encountered: