storage: More CheckSSTConflicts fixes #98519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Thanks. Should we re-enable range keys in kvnemesis here too? See #98475.
A few additional fixes around CheckSSTConflicts, stats calculations, and Next()ing logic, caught by kvnemesis. Hopefully the last of its kind. Also re-enable kvnemesis testing for range keys in AddSSTable, reverting cockroachdb#98475. Fixes cockroachdb#94141. Fixes cockroachdb#98473. Informs cockroachdb#94876. Epic: none Release note: None
itsbilal
force-pushed
the
sstconflicts-fixes-3
branch
from
34bffa5 to
9ec7760
Compare
|
@erikgrinaker TFTR! And yep, I've re-enabled it in the latest push. |
|
TFTR! bors r=erikgrinaker |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build failed: |
|
Timeout in UI tests. bors r=erikgrinaker |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few additional fixes around CheckSSTConflicts, stats calculations, and Next()ing logic, caught by kvnemesis. Hopefully the last of its kind.
Also re-enable kvnemesis testing for range keys in AddSSTable, reverting #98475.
Fixes #94141.
Fixes #98473.
Informs #94876.
Epic: none
Release note: None