-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv/kvnemesis: TestKVNemesisMultiNode failed #94876
Comments
cc @cockroachdb/replication |
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 51be9f048a59be0d4353498b447d162145384d13:
Parameters: |
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ e4924e2b9be4a36d466beab53a80df9241df4783:
Parameters: |
98472: changefeedccl: enable TestChangefeedPropagatesTerminalError r=samiskin a=samiskin Fixes: #95057 The test TestChangefeedPropagatesTerminalError no longer seems to flake after running it under stress on a GCE worker for a while, so this change re-enables it. Release note: None 98475: kvnemesis: disable `AddSSTable` range keys r=erikgrinaker a=erikgrinaker These trigger MVCC stats bugs in `CheckSSTConflicts`. Touches #94141. Touches #98473. Touches #94876. Epic: none Release note: None Co-authored-by: Shiranka Miskin <[email protected]> Co-authored-by: Erik Grinaker <[email protected]>
A few additional fixes around CheckSSTConflicts, stats calculations, and Next()ing logic, caught by kvnemesis. Hopefully the last of its kind. Fixes cockroachdb#94141. Fixes cockroachdb#98473. Informs cockroachdb#94876. Epic: none Release note: None
A few additional fixes around CheckSSTConflicts, stats calculations, and Next()ing logic, caught by kvnemesis. Hopefully the last of its kind. Also re-enable kvnemesis testing for range keys in AddSSTable, reverting cockroachdb#98475. Fixes cockroachdb#94141. Fixes cockroachdb#98473. Informs cockroachdb#94876. Epic: none Release note: None
98368: multiregionccl,server: use cached sqlliveness.Reader, deflake ColdStartLatencyTest r=ajwerner a=ajwerner #### multitenantccl: deflake ColdStartLatencyTest This test was flakey due to the closed timestamp sometimes not leading far for global tables due to overload, and due to a cached liveness reader not being used in distsql. The former was fixed in previous commits. The latter is fixed here. Fixes: #96334 #### sql: use CachedReader for uses with sqlinstance and the sql builtins The CachedReader won't block, which in multi-region clusters is good. It will mean that in some cases, it'll state that a sessions is alive when it most certainly is not. Currently, nobody needs synchronous semantics. This is a major part of fixing the TestColdStartLatency as sometimes distsql planning would block. That's not acceptable -- the idea that query physical planning can need to wait for a cross-region RPC is unacceptable. #### sqlliveness: re-arrange APIs to clarify when the API was blocking By "default" the implementation of Reader was blocking and there was a method to get a handle to a non-blocking CachedReader(). This asymmetry does not aid understandability. The non-blocking reader came later, but it is generally the more desirable interface. Release note: None 98519: storage: More CheckSSTConflicts fixes r=erikgrinaker a=itsbilal A few additional fixes around CheckSSTConflicts, stats calculations, and Next()ing logic, caught by kvnemesis. Hopefully the last of its kind. Also re-enable kvnemesis testing for range keys in AddSSTable, reverting #98475. Fixes #94141. Fixes #98473. Informs #94876. Epic: none Release note: None 98567: backupccl: use correct version gate for restore checkpointing r=adityamaru a=msbutler PR #97862 introduced a subtle bug which allowed the new restore checkpointing policy to take effect before the 23_1 migrations occured. This patch ensures the new policy only takes effect after all migrations occur. Release note: None Epic: None Co-authored-by: ajwerner <[email protected]> Co-authored-by: Bilal Akhtar <[email protected]> Co-authored-by: Michael Butler <[email protected]>
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 53dbb86acb1d48309530181b94838faf937084d3:
Parameters: |
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 53dbb86acb1d48309530181b94838faf937084d3:
Parameters: |
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ de5b08a418390a803357ba4b74a55a4eec26e16b:
Parameters: |
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ b89fa2cc4bc1fb9447ab1009b34b6f354f9618f0:
Parameters: |
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ b89fa2cc4bc1fb9447ab1009b34b6f354f9618f0:
Parameters: |
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 78bb7696847e1d8abf5d6a199c6dd3414a568691:
Parameters: |
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 5493fdfec4e1762c4502fb2f5d42fd28292c9c9d:
Parameters: Same failure on other branches
|
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 19a6b804d3aff74d74619a75cac3b52338c7aa02:
Parameters: Same failure on other branches
|
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 19a6b804d3aff74d74619a75cac3b52338c7aa02:
Parameters: Same failure on other branches
|
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 0fcc33bc2870961b9387999d8a9fed97fccbb2ae:
Parameters: Same failure on other branches
|
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ d107217dac5d817cc115bc0e97b7e53c0f2878bf:
Parameters: Same failure on other branches
|
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 2bd2c806ab3044569b09e0a205b5bc0452ad4e2b:
Parameters: Same failure on other branches
|
kv/kvnemesis.TestKVNemesisMultiNode failed with artifacts on master @ 7594fb2d1438dd5ed8f80a887b8d60b6cdd296ed:
Parameters:
TAGS=bazel,gss
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-23198
The text was updated successfully, but these errors were encountered: