jobs: avoid race conditions in tests #98458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
knz
force-pushed
the
20230312-knz-jobs-mutex
branch
from
d944c53 to
545a9a3
Compare
miretskiy
approved these changes
Mar 12, 2023
|
TFYR bors r=miretskiy |
|
Build failed: |
|
bors r=miretskiy |
|
Build failed: |
|
bors r=miretskiy |
craig bot
pushed a commit
that referenced
this pull request
Mar 12, 2023
98458: jobs: avoid race conditions in tests r=miretskiy a=knz Needed for #98440. Epic: CRDB-23559 When investigating jobs created during cluster migrations I found that the unit tests in the jobs packages have a race condition with the registry, because they register new job types (adding new constructors) concurrently with job adoption occurring during startup (using constructors). This patch fixes it. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
|
Build failed: |
|
bors r=miretskiy |
|
Build failed (retrying...): |
knz
force-pushed
the
20230312-knz-jobs-mutex
branch
from
545a9a3 to
d9d858b
Compare
|
Canceled. |
|
bors r=miretskiy |
When investigating jobs created during cluster migrations I found that the unit tests in the jobs package have a race condition with the registry, because they register new job types (adding new constructors) concurrently with job adoption occurring during startup (using constructors). This patch fixes it. Release note: None
knz
force-pushed
the
20230312-knz-jobs-mutex
branch
from
d9d858b to
e0cfcc1
Compare
|
Canceled. |
|
bors r=miretskiy |
|
Build failed (retrying...): |
|
This PR was included in a batch that was canceled, it will be automatically retried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #98440.
Epic: CRDB-23559
When investigating jobs created during cluster migrations I found that the unit tests in the jobs packages have a race condition with the registry, because they register new job types (adding new constructors) concurrently with job adoption occurring during startup (using constructors).
This patch fixes it.
Release note: None