upgrades,jobs: stub the auto config runner #98440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20230311-auto-config-job
branch
2 times, most recently
from
3a760ec to
c7819e1
Compare
knz
force-pushed
the
20230311-auto-config-job
branch
2 times, most recently
from
b4bbd28 to
82fb959
Compare
This was referenced Mar 11, 2023
knz
force-pushed
the
20230311-auto-config-job
branch
from
82fb959 to
92c3e7d
Compare
knz
force-pushed
the
20230311-auto-config-job
branch
from
92c3e7d to
919f208
Compare
craig bot
pushed a commit
that referenced
this pull request
Mar 12, 2023
98458: jobs: avoid race conditions in tests r=miretskiy a=knz Needed for #98440. Epic: CRDB-23559 When investigating jobs created during cluster migrations I found that the unit tests in the jobs packages have a race condition with the registry, because they register new job types (adding new constructors) concurrently with job adoption occurring during startup (using constructors). This patch fixes it. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
knz
force-pushed
the
20230311-auto-config-job
branch
from
919f208 to
4d20185
Compare
knz
force-pushed
the
20230311-auto-config-job
branch
from
4d20185 to
ad19f6a
Compare
knz
force-pushed
the
20230311-auto-config-job
branch
from
ad19f6a to
d4e795e
Compare
knz
force-pushed
the
20230311-auto-config-job
branch
2 times, most recently
from
9c00e99 to
6cce3af
Compare
knz
force-pushed
the
20230311-auto-config-job
branch
from
c122a8c to
b6824ff
Compare
knz
force-pushed
the
20230311-auto-config-job
branch
3 times, most recently
from
c31f79a to
5d550d4
Compare
This change is part of a larger project to perform auto-configuration in newly created clusters. One of the components will be the "auto config runner", a job which receives configuration to apply from the environment, creates other jobs to apply this configuration, and stores the execution results. This commit stubs the job, which means allocating a cluster version for it and instantiating it via a cluster migration. The job is otherwise idle at this point. Release note: None
knz
force-pushed
the
20230311-auto-config-job
branch
3 times, most recently
from
e7f845f to
82db75b
Compare
|
bors r=stevendanna,ajwerner |
|
bors r- |
|
Canceled. |
|
bors r=stevendanna,ajwerner |
knz
force-pushed
the
20230311-auto-config-job
branch
from
82db75b to
1eba4bd
Compare
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Release note: None
knz
force-pushed
the
20230311-auto-config-job
branch
from
1eba4bd to
56c64e3
Compare
|
Canceled. |
|
bors r=stevendanna,ajwerner |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-23559
Informs #98431.
This change is part of a larger project to perform auto-configuration in newly created clusters. One of the components will be the "auto config runner", a job which receives configuration to apply from the environment, creates other jobs to apply this configuration, and stores the execution results.
This commit stubs the job, which means allocating a cluster version for it and instantiating it via a cluster migration. The job is otherwise idle at this point.
Release note: None