roachtest: unskip kv/restart/nodes=12 #98271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvoli
requested review from
herkolategan and
smg260
and removed request for
a team
|
This change is |
kvoli
force-pushed
the
230308.enable-kvrestart
branch
from
7991141 to
9a74732
Compare
herkolategan
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @smg260)
pkg/cmd/roachtest/tests/kv.go line 920 at r1 (raw file):
r.Add(registry.TestSpec{ Name: "kv/restart/nodes=12", // This test is expensive (104vcpu), we run it weekly.
White space character might be off here and tripping the linter. Nothing a quick bin/crlfmt won't fix.
|
Could we also fix the PR/issue reference in the commit? |
kvoli
force-pushed
the
230308.enable-kvrestart
branch
from
9a74732 to
faaa0d9
Compare
|
Created an issue for unskipping. Linked. |
kvoli
force-pushed
the
230308.enable-kvrestart
branch
from
faaa0d9 to
5d40807
Compare
|
I meant this line in the commit message:
The PR referenced there is not the right one, is it? It's a documentation change from 2016. |
|
Ah I see - nice find. I'll update. |
Previously, the `kv/restart/nodes=12` roachtest was unable to pass and was skipped. Following the changes introduced for cockroachdb#96521, the test now passes. This commit enables the `kv/restart/nodes=12` roachtest as a weekly test. resolves: cockroachdb#98296 Release note: None
kvoli
force-pushed
the
230308.enable-kvrestart
branch
from
5d40807 to
b3d3e64
Compare
|
bors r=andrewbaptist |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
kv/restart/nodes=12roachtest was unable to pass andwas skipped. Following the changes introduced for #96521, the test now
passes.
This commit enables the
kv/restart/nodes=12roachtest as a weeklytest.
resolves: #98296
Release note: None