Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: unskip kv/restart/nodes=12 #98296

Closed
kvoli opened this issue Mar 9, 2023 · 0 comments · Fixed by #98271
Closed

roachtest: unskip kv/restart/nodes=12 #98296

kvoli opened this issue Mar 9, 2023 · 0 comments · Fixed by #98271
Assignees
@kvoli
Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@kvoli
Copy link
Collaborator

kvoli commented Mar 9, 2023 •
edited
Loading

Following the changes introduced for #96521, the test now reliably passes.

We should re-enable it on a weekly basis for regression detection.

Jira issue: CRDB-25175
@kvoli kvoli added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-distribution Relating to rebalancing and leasing. labels Mar 9, 2023
@kvoli kvoli self-assigned this Mar 9, 2023
@blathers-crl blathers-crl bot added the T-kv KV Team label Mar 9, 2023
kvoli added a commit to kvoli/cockroach that referenced this issue Mar 9, 2023
@kvoli
roachtest: unskip kv/restart/nodes=12
faaa0d9 
Previously, the `kv/restart/nodes=12` roachtest was unable to pass and
was skipped. Following the changes introduced for cockroachdb#9652, the test now
passes.

This commit enables the `kv/restart/nodes=12` roachtest as a weekly
test.

informs: cockroachdb#95159
resolves: cockroachdb#98296

Release note: None
@kvoli kvoli mentioned this issue Mar 9, 2023
Merged
kvoli added a commit to kvoli/cockroach that referenced this issue Mar 9, 2023
@kvoli
roachtest: unskip kv/restart/nodes=12
5d40807 
Previously, the `kv/restart/nodes=12` roachtest was unable to pass and
was skipped. Following the changes introduced for cockroachdb#9652, the test now
passes.

This commit enables the `kv/restart/nodes=12` roachtest as a weekly
test.

resolves: cockroachdb#98296

Release note: None
craig bot pushed a commit that referenced this issue Mar 9, 2023
@kvoli
Merge #98271
deb3f94 
98271: roachtest: unskip kv/restart/nodes=12 r=andrewbaptist a=kvoli

Previously, the `kv/restart/nodes=12` roachtest was unable to pass and
was skipped. Following the changes introduced for #96521, the test now
passes.

This commit enables the `kv/restart/nodes=12` roachtest as a weekly
test.

resolves: #98296

Release note: None

Co-authored-by: Austen McClernon <[email protected]>
@craig craig bot closed this as completed in b3d3e64 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvoli kvoli

Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: unskip kv/restart/nodes=12 kvoli/cockroach
1 participant
@kvoli