Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add tpcc roachperf test variants to stress encryption #97923

Merged
merged 1 commit into from
Mar 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 42 additions & 7 deletions pkg/cmd/roachtest/tests/tpcc.go
Original file line number Diff line number Diff line change
Expand Up @@ -961,6 +961,9 @@ type tpccBenchSpec struct {
MinVersion string
// Tags to pass to testRegistryImpl.Add.
Tags []string
// EncryptionEnabled determines if the benchmark uses encrypted stores (i.e.
// Encryption-At-Rest / EAR).
EncryptionEnabled bool
}

// partitions returns the number of partitions specified to the load generator.
Expand Down Expand Up @@ -1029,6 +1032,12 @@ func registerTPCCBenchSpec(r registry.Registry, b tpccBenchSpec) {
panic("unexpected")
}

encryptionSupport := registry.EncryptionAlwaysDisabled
if b.EncryptionEnabled {
encryptionSupport = registry.EncryptionAlwaysEnabled
nameParts = append(nameParts, "enc=true")
}

name := strings.Join(nameParts, "/")

numNodes := b.Nodes + b.LoadConfig.numLoadNodes(b.Distribution)
Expand All @@ -1040,13 +1049,11 @@ func registerTPCCBenchSpec(r registry.Registry, b tpccBenchSpec) {
}

r.Add(registry.TestSpec{
Name: name,
Owner: owner,
Cluster: nodes,
Tags: b.Tags,
// NB: intentionally not enabling encryption-at-rest to produce
// consistent results.
EncryptionSupport: registry.EncryptionAlwaysDisabled,
Name: name,
Owner: owner,
Cluster: nodes,
Tags: b.Tags,
EncryptionSupport: encryptionSupport,
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runTPCCBench(ctx, t, c, b)
},
Expand Down Expand Up @@ -1501,6 +1508,34 @@ func registerTPCCBench(r registry.Registry) {
LoadWarehouses: 10000,
EstimatedMax: 8000,
},

// Encryption-At-Rest benchmarks. These are duplicates of variants above,
// using encrypted stores.
{
Nodes: 3,
CPUs: 4,

LoadWarehouses: 1000,
EstimatedMax: 325,
EncryptionEnabled: true,
},
{
Nodes: 3,
CPUs: 16,

LoadWarehouses: 2000,
EstimatedMax: 1300,
EncryptionEnabled: true,
},
{
Nodes: 12,
CPUs: 16,

LoadWarehouses: 10000,
EstimatedMax: 6000,
LoadConfig: singlePartitionedLoadgen,
EncryptionEnabled: true,
},
}

for _, b := range specs {
Expand Down