roachtest: add tpcc roachperf test variants to stress encryption #97923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktrav
requested review from
herkolategan and
renatolabs
and removed request for
a team
|
This change is |
srosenberg
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @herkolategan, @jbowens, @nicktrav, and @renatolabs)
pkg/cmd/roachtest/tests/tpcc.go line 966 at r1 (raw file):
// EncryptionSupport determines if the benchmark uses encrypted stores (i.e. // Encryption-At-Rest / EAR). EncryptionSupport bool
Nit: might be less ambiguous to rename to EncryptionEnabled since EncryptionSupport is (also) a three-valued type.
Currently, certain KV roachperf variants run with Encryption-At-Rest (EAR) support (i.e. `enc=true`). Expand the test variants to include three basic TPC-C configurations with EAR enabled: - 3 nodes, 4 vCPU - 3 nodes, 16 vCPU - 12 nodes, 16 vCPU Release note: None.
nicktrav
force-pushed
the
nickt.tpcc-bench-enc
branch
from
61a4a0f to
2c428db
Compare
nicktrav
commented
Mar 2, 2023
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/tpcc.go line 966 at r1 (raw file):
Previously, srosenberg (Stan Rosenberg) wrote…
Nit: might be less ambiguous to rename to
EncryptionEnabledsinceEncryptionSupportis (also) a three-valued type.
Good call. Done.
|
TFTR! bors r=srosenberg |
|
Build succeeded: |
nicktrav
added a commit
to nicktrav/cockroach
that referenced
this pull request
Mar 6, 2023
This is a follow up to cockroachdb#97923, adding the roachperf variants as tests, rather than benchmarks. Release note: None.
craig bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
98106: roachtest: wire up additional tpcc benchmarks r=srosenberg a=nicktrav This is a follow up to #97923, adding the roachperf variants as tests, rather than benchmarks. Release note: None. Epic: CRDB-20293 Co-authored-by: Nick Travers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, certain KV roachperf variants run with Encryption-At-Rest (EAR) support (i.e.
enc=true). Expand the test variants to include three basic TPC-C configurations with EAR enabled:Release note: None.
Epic: CRDB-20293.