kvserver: fix rebalance obj test on arm mac #96947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
force-pushed
the
230210.split-obj-risc
branch
from
835930e to
0764023
Compare
pav-kv
approved these changes
Feb 10, 2023
kvoli
force-pushed
the
230210.split-obj-risc
branch
from
0764023 to
e76218a
Compare
|
TYFTR |
|
bors r=pavelkalinnikov |
|
Build failed (retrying...): |
|
Build failed: |
Previosly,`TestRebalanceObjectiveManager` and `TestLoadBasedRebalancingObjective` would assert assuming that it was possible for the test host to use `grunning`, however this is not true for ARM Mac. This patch ammends these tests to test a subset of behavior when `grunning` isn't supported and then exit. Fixes: cockroachdb#96934 Release note: None
kvoli
force-pushed
the
230210.split-obj-risc
branch
from
e76218a to
4c2d4c3
Compare
|
bors r=pavelkalinnikov |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previosly,
TestRebalanceObjectiveManagerandTestLoadBasedRebalancingObjectivewould assert assuming that it was possible for the test host to usegrunning, however this is not true for ARM Mac.This patch ammends these tests to test a subset of behavior when
grunningisn't supported and then exit.Fixes: #96934
Release note: None