Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: TestLoadBasedRebalancingObjective failed #96934

Closed
pav-kv opened this issue Feb 10, 2023 · 3 comments · Fixed by #96947
Closed

kvserver: TestLoadBasedRebalancingObjective failed #96934

pav-kv opened this issue Feb 10, 2023 · 3 comments · Fixed by #96947
Assignees
@kvoli
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@pav-kv
Copy link
Collaborator

pav-kv commented Feb 10, 2023 •
edited by cockroach-jira-scripts
Loading

Describe the problem

--- FAIL: TestLoadBasedRebalancingObjective (0.01s)
    test_log_scope.go:161: test logs captured to: /Users/pavel/go/src/github.com/cockroachdb/cockroach/tmp/_tmp/577bfc8ed46850d1aaafa923fa37ce78/logTestLoadBasedRebalancingObjective4012545181
    test_log_scope.go:79: use -show-logs to present logs inline
    --- FAIL: TestLoadBasedRebalancingObjective/latest_version_supports_all_rebalance_objectives (0.00s)
        rebalance_objective_test.go:95: 
                Error Trace:    /private/var/tmp/_bazel_pavel/9feea0c38530dc9f20105ecc8935971a/sandbox/darwin-sandbox/2762/execroot/com_github_cockroachdb_cockroach/bazel-out/darwin_arm64-fastbuild/bin/pkg/kv/kvserver/kvserver_test_/kvserver_test.runfiles/com_github_cockroachdb_cockroach/pkg/kv/kvserver/rebalance_objective_test.go:95
                Error:          Not equal: 
                                expected: 1
                                actual  : 0
                Test:           TestLoadBasedRebalancingObjective/latest_version_supports_all_rebalance_objectives
    rebalance_objective_test.go:151: -- test log scope end --
FAIL

To Reproduce

Fails consistently on MacOS with:

dev test pkg/kv/kvserver --filter=TestLoadBasedRebalancingObjective

Jira issue: CRDB-24417
@pav-kv pav-kv added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Feb 10, 2023
@pav-kv
Copy link
Collaborator Author

pav-kv commented Feb 10, 2023

Same story with TestRebalanceObjectiveManager that was introduced in the same commit #96127.

@kvoli
Copy link
Collaborator

kvoli commented Feb 10, 2023 •
edited
Loading

It looks like it is broken on MacOS (risc) because it asserts that grunning is supported. I'm not at my pc right now but adding a check that just returns from those tests if grunning isn't supported will fix this.

I developed on Ubuntu (gceworker). It should still pass CI?

@pav-kv
Copy link
Collaborator Author

pav-kv commented Feb 10, 2023

Yes, it seems like CI is ok. I'm t.Skip()-ing them locally.

@kvoli kvoli mentioned this issue Feb 10, 2023
Merged
craig bot pushed a commit that referenced this issue Feb 10, 2023
@dhartunian @kvoli
@rafiss @nicktrav @msbutler
Merge #96881 #96947 #96957 #96964 #96985
8c2060c 
96881: servercontroller: serve http from default tenant on error r=aadityasondhi a=dhartunian

Previously, when an HTTP request arrived with a tenant cookie attached, we would attempt to connect to that tenant and fail if the tenant couldn't be started or if it didn't exist. This causes a bad user-facing experience when someone's browser contains stale tenant cookies and they attempt to load DB Console. The error returns a 500 to the browser and user sees no UI, can't try and login again, and is basically stuck until they clear their cookies.

This change falls back to serving HTTP from the default tenant when the requested one can't be reached. This ensures that *something* is served to ensure that unauthenticated endpoints can still be loaded in these scenarios and users can attempt to login again.

Epic: CRDB-12100

Release note: None

96947: kvserver: fix rebalance obj test on arm mac r=pavelkalinnikov a=kvoli

Previosly,`TestRebalanceObjectiveManager` and
`TestLoadBasedRebalancingObjective` would assert assuming that it was possible for the test host to use `grunning`, however this is not true for ARM Mac.

This patch ammends these tests to test a subset of behavior when `grunning` isn't supported and then exit.

Fixes: #96934

Release note: None

96957: sql: fix SHOW GRANTS FOR public r=ecwall a=rafiss

fixes #96948

Release note (bug fix): Fixed the `SHOW GRANTS FOR public` command so it works correctly. Previously, this would return an error saying that the `public` role does not exist.

96964: roachtest: set range tombstones flag accordingly r=jbowens,msbutler a=nicktrav

Fix a bug in the `import-cancellation` roachtest whereby range tombstones are always disabled.

Release note: None.

Epic: CRDB-20465

96985: roachtest: disable scheduled backup in rust-postgres node restart r=rafiss a=msbutler

Fixes #96799

Release note: None

Co-authored-by: David Hartunian <[email protected]>
Co-authored-by: Austen McClernon <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Nick Travers <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
@craig craig bot closed this as completed in 4c2d4c3 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvoli kvoli

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: fix rebalance obj test on arm mac kvoli/cockroach
2 participants
@pav-kv @kvoli