-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: tenant: add support to Log endpoints to status server #96906
release-22.2: tenant: add support to Log endpoints to status server #96906
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
1cb22ba
to
8bc55af
Compare
I made a small change to get the patch to build on 22.2. sqlInstanceProvider was renamed to sqlInstanceReader. |
8bc55af
to
e60ab70
Compare
Previously, the tenant status server did not support the log-file related endpoints leading to missing logs in the debug.zip when generating for a tenant server. This commit migrates the implementations from the standard status server into the tenant, adjusts for fanout to instances instead of nodes, and leaves the rest as-is. Resolves: cockroachdb#91992 Epic: CC-5168 Release note (ops change): generating a debug.zip for a tenant server will now include logs in the zip file.
e60ab70
to
88368db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small change to get the patch to build on 22.2. sqlInstanceProvider was renamed to sqlInstanceReader.
👍
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @jeffswenson)
pkg/cli/testdata/zip/testzip_tenant
line 144 at r1 (raw file):
[node 1] 0 goroutine dumps found [node 1] requesting log file ... [node 1] 0 log file ...
I'm surprised this test didn't have to change on the original PR. Do you know why?
It looks like the test is skipped: cockroach/pkg/cli/zip_tenant_test.go Line 34 in 5f310bc
|
Backport 1/1 commits from #91604.
/cc @cockroachdb/release
Release justification: Including logs in debug zips simplifies debugging issues in multi-tenant deploys.
Previously, the tenant status server did not support the log-file related
endpoints leading to missing logs in the debug.zip when generating for a tenant
server.
This commit migrates the implementations from the standard status server into
the tenant, adjusts for fanout to instances instead of nodes, and leaves the
rest as-is.
Resolves: #91992
Epic: CC-5168
Release note (ops change): generating a debug.zip for a tenant server will now
include logs in the zip file.