-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tenant: add support to Log endpoints to status server #91604
tenant: add support to Log endpoints to status server #91604
Conversation
The tenant and non-tenant status servers will be merged for 23.1, but this PR is intended for backporting so we can support logs in debug.zip for 22.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're in agreement this will eventually become a single implementation shared with status.go
, right?
no objection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- you are a hero with this turnaround time!
I went ahead and tested on a cluster where multiple SQL instances were running for a single tenant. Logs were collected from all instances 🎉
Reviewable status: complete! 1 of 0 LGTMs obtained
9a7c460
to
90d86ef
Compare
Previously, the tenant status server did not support the log-file related endpoints leading to missing logs in the debug.zip when generating for a tenant server. This commit migrates the implementations from the standard status server into the tenant, adjusts for fanout to instances instead of nodes, and leaves the rest as-is. Resolves: cockroachdb#91992 Epic: CC-5168 Release note (ops change): generating a debug.zip for a tenant server will now include logs in the zip file.
90d86ef
to
8e31f56
Compare
bors r=abarganier, knz |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 8e31f56 to blathers/backport-release-22.2-91604: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 403 Resource not accessible by integration [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, the tenant status server did not support the log-file related
endpoints leading to missing logs in the debug.zip when generating for a tenant
server.
This commit migrates the implementations from the standard status server into
the tenant, adjusts for fanout to instances instead of nodes, and leaves the
rest as-is.
Resolves: #91992
Epic: CC-5168
Release note (ops change): generating a debug.zip for a tenant server will now
include logs in the zip file.