Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix r.end_key after comparison in show_range_for_row #96721

Merged
merged 1 commit into from
Feb 7, 2023
Merged

sql: fix r.end_key after comparison in show_range_for_row #96721

merged 1 commit into from
Feb 7, 2023

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Feb 7, 2023

Fixes #96714

Flip the < to > in show_range_for_row to be consistent with show_ranges.go:

    WHEN r.end_key < crdb_internal.table_span(%[1]d)[2] THEN '<after:'||crdb_internal.pretty_key(r.end_key,-1)||'>'

becomes

    WHEN r.end_key > crdb_internal.table_span(%[1]d)[2] THEN '<after:'||crdb_internal.pretty_key(r.end_key,-1)||'>'

Release note: None

@ecwall ecwall requested a review from knz February 7, 2023 15:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

knz
knz approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 💯

@ecwall
sql: fix r.end_key after comparison in show_range_for_row
8e3c2fd 
Fixes #96714

Flip the `<` to `>` in `show_range_for_row` to be consistent with `show_ranges.go`:
```
    WHEN r.end_key < crdb_internal.table_span(%[1]d)[2] THEN '<after:'||crdb_internal.pretty_key(r.end_key,-1)||'>'
```
becomes
```
    WHEN r.end_key > crdb_internal.table_span(%[1]d)[2] THEN '<after:'||crdb_internal.pretty_key(r.end_key,-1)||'>'
```

Release note: None
@ecwall ecwall requested a review from rafiss February 7, 2023 19:53
@ecwall
Copy link
Contributor Author

ecwall commented Feb 7, 2023

bors r=knz

@craig
Copy link
Contributor

craig bot commented Feb 7, 2023

Build succeeded:

@craig craig bot merged commit 0a65a4e into cockroachdb:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz approved these changes

@rafiss rafiss Awaiting requested review from rafiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: fix r.end_key after comparison in show_range_for_row
3 participants
@ecwall @cockroach-teamcity @knz