Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix r.end_key after comparison in show_range_for_row #96714

Closed
ecwall opened this issue Feb 7, 2023 · 0 comments · Fixed by #96721
Closed

sql: fix r.end_key after comparison in show_range_for_row #96714

ecwall opened this issue Feb 7, 2023 · 0 comments · Fixed by #96721
Assignees
@ecwall
Labels
A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ecwall
Copy link
Contributor

ecwall commented Feb 7, 2023 •
edited
Loading

The < sign should be flipped to > in show_range_for_row to be consistent with show_ranges.go

    WHEN r.end_key < crdb_internal.table_span(%[1]d)[2] THEN '<after:'||crdb_internal.pretty_key(r.end_key,-1)||'>'

should be

    WHEN r.end_key > crdb_internal.table_span(%[1]d)[2] THEN '<after:'||crdb_internal.pretty_key(r.end_key,-1)||'>'

Jira issue: CRDB-24291

Epic CRDB-23344
@ecwall ecwall added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Feb 7, 2023
@ecwall ecwall self-assigned this Feb 7, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Feb 7, 2023
@ecwall ecwall added the A-multitenancy Related to multi-tenancy label Feb 7, 2023
@ecwall ecwall mentioned this issue Feb 7, 2023
Merged
craig bot pushed a commit that referenced this issue Feb 7, 2023
@rafiss @ecwall
Merge #96386 #96675 #96721 #96726
0a65a4e 
96386: importer: add deprecation notice for mysqldump/pgdump r=rafiss a=rafiss

fixes: #93660

Release note (sql change): The PGDUMP and MYSQLDUMP formats for IMPORT were marked as deprecated. They are still present, but will be removed in a future release. The page at https://www.cockroachlabs.com/docs/v22.2/migration-overview shows alternatives.

96675: roachtest: fix sqlalchemy version pinning r=e-mbrown a=rafiss

fixes #96090
backports needed for #96081 and #96059

The test setup was wrong, and was always using the latest sqlalchemy. This fixes the pinning, and also updates to a newer version.

Release note: None

96721: sql: fix r.end_key after comparison in show_range_for_row r=knz a=ecwall

Fixes #96714

Flip the `<` to `>` in `show_range_for_row` to be consistent with `show_ranges.go`:
```
    WHEN r.end_key < crdb_internal.table_span(%[1]d)[2] THEN '<after:'||crdb_internal.pretty_key(r.end_key,-1)||'>'
```
becomes
```
    WHEN r.end_key > crdb_internal.table_span(%[1]d)[2] THEN '<after:'||crdb_internal.pretty_key(r.end_key,-1)||'>'
```

Release note: None

96726: sql: use unimplemented error rather than syntax error for PL/pgSQL r=chengxiong-ruan,mgartner a=rafiss

fixes #96720

This change does not affect anything user-facing, but it allows us to parse CREATE FUNCTION statements that use `LANGUAGE plpgsql`. The plpgsql grammar is still not supported, so this will still show an error to the user. However, since parsing succeeds, the statement will be sent to telemetry logs, allowing us to analyze which parts of the plpgsql grammar that customers are trying to use.

Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Evan Wall <[email protected]>
@craig craig bot closed this as completed in 8e3c2fd Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecwall ecwall

Labels
A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: fix r.end_key after comparison in show_range_for_row
1 participant
@ecwall