Revert "sql: improve stack trace for get-user-timeout timeouts" #96504
+0
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 662e19c. gRPC does note expect the context to be wrapped, so it can get confused. Release note: None
|
This change is |
ecwall
approved these changes
Feb 3, 2023
|
tftr! bors r=ecwall |
|
bors r- #96483 might replace this |
|
Canceled. |
otan
approved these changes
Feb 5, 2023
|
as a release branch is getting prepped soon (tomorrow or day after IIRC), we either need to decide to merge this or the other change before then. |
|
this is on the master branch. is a release being cut from here? the 22.1 revert already was merged. |
|
#96505 22.2 doesn't look merged :D oops, i think master is fine but we should pull the trigger on 22.2 |
|
yeah, I'm fine to merge that. the next 22.2 tag is scheduled for next week I think. |
|
bors r=ecwall |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 662e19c.
gRPC does not expect the context to be wrapped, so it can get confused.
informs #95794
Release note: None