release-22.1: Revert "sql: improve stack trace for get-user-timeout timeouts" #96474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
changed the title
rafiss
approved these changes
Feb 2, 2023
otan
approved these changes
Feb 2, 2023
|
I realized that to get more information on https://github.com/cockroachlabs/support/issues/2017, the support team is hoping to have better logging for get-user-timeout in v22.1.14. Since we just reverted this change, hopefully we can improve the logging at least in this one specific place, even if we don't change |
|
have we done this on the other branches? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 60e3926.
Fixes #96167
Reverting due to failing test test_quit.tcl.
Release justification: resolve broken test
Release note: None