sql: randomize optimizer testing knobs in most tests #94936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
randomize-opt
branch
2 times, most recently
from
82cd470 to
9a12066
Compare
craig bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
94949: sql: propagate the settings properly into the stmt bundle builder r=yuzefovich a=yuzefovich A few months ago we extended the collection of the cluster settings into the stmt bundle to also get the global default value. That getter method takes in a pointer to the current cluster settings' values, and we passed nil. This can cause nil pointer errors and is now fixed. Found when working on #94936. Epic: None Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
yuzefovich
force-pushed
the
randomize-opt
branch
2 times, most recently
from
9748042 to
abc8ed8
Compare
This commit makes it so that we randomize the default values for `testing_optimizer_cost_perturbation` and `testing_optimizer_disable_rule_probability` session variables in `crdb_test` builds. The only exceptions are the execbuilder and the SQLite logic tests in which we override the newly-introduced corresponding cluster settings to 0. Release note: None
yuzefovich
force-pushed
the
randomize-opt
branch
from
abc8ed8 to
07ebeff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it so that we randomize the default values for
testing_optimizer_cost_perturbationandtesting_optimizer_disable_rule_probabilitysession variables incrdb_testbuilds. The only exceptions are the execbuilder and the SQLite logic tests in which we override the newly-introduced corresponding cluster settings to 0.Fixes: #93825.
Release note: None