Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: use optimizer cost perturbation and disable rule settings for metamorphic testing #93825

Open
rytaft opened this issue Dec 16, 2022 · 2 comments
Open

sql: use optimizer cost perturbation and disable rule settings for metamorphic testing #93825

rytaft opened this issue Dec 16, 2022 · 2 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team

Comments

@rytaft
Copy link
Collaborator

rytaft commented Dec 16, 2022 •
edited
Loading

We created session settings testing_optimizer_cost_perturbation and testing_optimizer_disable_rule_probability to use for the randomized tests costfuzz and unoptimized_query_oracle. We should also use them as metamorphic constants that are used with metamorphic testing. This will give us more test coverage.

Jira issue: CRDB-22542
@rytaft rytaft added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Dec 16, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Dec 16, 2022
@rytaft
Copy link
Collaborator Author

rytaft commented Dec 20, 2022

Since these flags will make plans slow, we should probably not enable these flags on SQLite.

@yuzefovich yuzefovich mentioned this issue Jan 9, 2023
Closed
@yuzefovich
Copy link
Member

I looked into this in #94936, but there were quite a few failures and I since lost the context on it, so unassigning myself and putting into 23.2 bucket.

@yuzefovich yuzefovich removed their assignment Feb 15, 2023
@mgartner mgartner moved this to New Backlog in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: randomize optimizer testing knobs in most tests yuzefovich/cockroach
2 participants
@rytaft @yuzefovich