sql: add replication start time to SHOW TENANT WITH REPLICATION STATUS
#93551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
lidorcarmel
approved these changes
Dec 13, 2022
| // TODO(lidor): replace this start time with the actual replication start time when we have it. | ||
| require.GreaterOrEqual(t, protectedTime, testStartTime) | ||
| require.GreaterOrEqual(t, protectedTime, replicationDetails.ReplicationStartTime.GoTime()) | ||
| require.Equal(t, replicationStartTime.UnixNano(), replicationDetails.ReplicationStartTime.GoTime().UnixNano()) |
There was a problem hiding this comment.
can you drop the UnixNano()?
There was a problem hiding this comment.
The test flake actually revealed that the replicationStartTime is only accurate up to the microsecond after we start running into rounding mismatches. I had to change this to UnixMicro to pass under stress on a gceworker.
adityamaru
force-pushed
the
start-time-show
branch
from
2bb4ef6 to
6bb6d1c
Compare
The start time is an important and useful piece of information to expose to the end user. It is the lower bound for the data we have replicated. Release note: None
adityamaru
force-pushed
the
start-time-show
branch
from
6bb6d1c to
3833eed
Compare
|
Tracking the unrelated flake here #93731 bors r=lidorcarmel |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start time is a useful piece of information to expose to the end user. It is the lower bound for the data we have replicated.
Informs: #93447
Release note: None