Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c2c: SHOW TENANT...REPLICATION should show more #93447

Closed
adityamaru opened this issue Dec 12, 2022 · 4 comments · Fixed by #94285
Closed

c2c: SHOW TENANT...REPLICATION should show more #93447

adityamaru opened this issue Dec 12, 2022 · 4 comments · Fixed by #94285
Assignees
@adityamaru
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@adityamaru
Copy link
Contributor

adityamaru commented Dec 12, 2022 •
edited by cockroach-jira-scripts
Loading

Once #92788 merges, we should add StartTime to the output of SHOW TENANT WITH REPLICATION STATUS. Additionally, we should add the replication job error reason if present. Both of these pieces of information are important for observability.

Epic: CRDB-18752

Jira issue: CRDB-22337
@adityamaru adityamaru added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-disaster-recovery labels Dec 12, 2022
@blathers-crl
Copy link

blathers-crl bot commented Dec 12, 2022

cc @cockroachdb/disaster-recovery

@blathers-crl
Copy link

blathers-crl bot commented Dec 12, 2022

cc @cockroachdb/disaster-recovery

@adityamaru adityamaru mentioned this issue Dec 13, 2022
Merged
@dt dt changed the title c2c: SHOW TENANT should show StartTime and replication job error c2c: SHOW TENANT...REPLICATION should show more Dec 14, 2022
craig bot pushed a commit that referenced this issue Dec 15, 2022
@fqazi @adityamaru
@samiskin @cockroach-teamcity
Merge #92971 #93551 #93552 #93682
2c2822c 
92971: sql/schemachanger: enable drop index by default r=fqazi a=fqazi

This patch will enable drop index by default in the declarative schema changer with the following fixes:

Fixes: #93070

1. Return proper index names for errors
2. Some index notices should only be generated when work is done
3. Views and indexes should have to be cleaned together when the index becomes invisible.
4. Drop index should return correct errors in system tables
5. Enable drop index by default and update logic tests

Current limitations for falling back are if there are foreign key constraint dependencies or zone configs

93551: sql: add replication start time to `SHOW TENANT WITH REPLICATION STATUS` r=lidorcarmel a=adityamaru

The start time is a useful piece of information to expose to the end user. It is the lower bound for the data we have replicated.

Informs: #93447

Release note: None

93552: changefeedccl: increase chaos roachtest latency limits r=samiskin a=samiskin

Resolves: #93238

Since our job-level retry MaxBackoff has increased from 10 seconds to 10 minutes, increase the chaos test latency limits.

Release note: None

93682: ci: update bazel builder image r=rickystewart a=cockroach-teamcity

Release note: None
Epic: None


Co-authored-by: Faizan Qazi <[email protected]>
Co-authored-by: adityamaru <[email protected]>
Co-authored-by: Shiranka Miskin <[email protected]>
Co-authored-by: cockroach-teamcity <[email protected]>
@adityamaru
Copy link
Contributor Author

We decided that showing the start_time to the user is not useful. We already show the replicated_time and retention_time that is sufficient to pick a cutover time, and fingerprint start time.

@adityamaru adityamaru mentioned this issue Dec 25, 2022
Merged
@shermanCRL
Copy link
Contributor

I could imagine a user wishing to know how long a replication stream has been running. Doesn’t necessarily imply it needs to be in this SHOW view, per se.

@craig craig bot closed this as completed in 9317a5f Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityamaru adityamaru

Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "sql: add replication start time to SHOW TENANT WITH REPLICATION STATUS adityamaru/cockroach
2 participants
@adityamaru @shermanCRL