Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/pgwire: skip TestParseClientProvidedSessionParameters #93506

Conversation

renatolabs
Copy link
Contributor

@renatolabs renatolabs commented Dec 13, 2022

Refs: #93469

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Resolves #93500
Epic: None
Release note: None

Refs: cockroachdb#93469

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@renatolabs renatolabs requested a review from a team December 13, 2022 14:59
@renatolabs renatolabs requested a review from a team as a code owner December 13, 2022 14:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor

knz commented Dec 13, 2022

Is the cause not #93500?

@renatolabs
Copy link
Contributor Author

Is the cause not #93500?

I chose to use #93469 as that was created first and there was already ongoing discussion there.

@renatolabs
Copy link
Contributor Author

bors r=knz

Copy link
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it close #93500, while leaving #93469 alive.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @yuzefovich)

@craig
Copy link
Contributor

craig bot commented Dec 13, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 13, 2022

Build failed (retrying...):

@yuzefovich
Copy link
Member

let's bump the priority here too

@yuzefovich
Copy link
Member

bors r+ p=999

@craig
Copy link
Contributor

craig bot commented Dec 13, 2022

Already running a review

@craig
Copy link
Contributor

craig bot commented Dec 13, 2022

Build succeeded:

@craig craig bot merged commit 1ee3989 into cockroachdb:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/pgwire: TestParseClientProvidedSessionParameters failed
5 participants