Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/pgwire: TestParseClientProvidedSessionParameters failed #93500

Closed
cockroach-teamcity opened this issue Dec 13, 2022 · 3 comments · Fixed by #93506
Closed

sql/pgwire: TestParseClientProvidedSessionParameters failed #93500

cockroach-teamcity opened this issue Dec 13, 2022 · 3 comments · Fixed by #93506
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 13, 2022 •
edited by cockroach-jira-scripts
Loading

sql/pgwire.TestParseClientProvidedSessionParameters failed with artifacts on master @ 99e7bd7e72741106fb6da9cc1fbbaf35bc7b9fde:

        	Error:      	Expect "unexpected protocol version: 80877102" to match "remote port is not numeric"
        	Test:       	TestParseClientProvidedSessionParameters/remote_addr_port_must_be_numeric
    --- FAIL: TestParseClientProvidedSessionParameters/remote_addr_port_must_be_numeric (0.00s)
=== RUN   TestParseClientProvidedSessionParameters/success_setting_remote_address_from_query
    conn_test.go:1539: 
        	Error Trace:	/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/2281/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/pgwire_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/pgwire/conn_test.go:1539
        	            				/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/2281/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/pgwire_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/pgwire/conn_test.go:1584
        	Error:      	Received unexpected error:
        	            	unexpected protocol version: 80877102
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/sql/pgwire.getSessionArgs
        	            	  | 	github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:567
        	            	  | github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestParseClientProvidedSessionParameters.func26
        	            	  | 	github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:1583
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1446
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1594
        	            	Wraps: (2) unexpected protocol version: 80877102
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestParseClientProvidedSessionParameters/success_setting_remote_address_from_query
    --- FAIL: TestParseClientProvidedSessionParameters/success_setting_remote_address_from_query (0.00s)
=== RUN   TestParseClientProvidedSessionParameters/crdb:jwt_auth_enabled_must_be_a_boolean_if_provided
    conn_test.go:1508: 
        	Error Trace:	/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/2281/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/pgwire_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/pgwire/conn_test.go:1508
        	            				/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/2281/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/pgwire_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/pgwire/conn_test.go:1584
        	Error:      	Expect "unexpected protocol version: 80877102" to match "crdb:jwt_auth_enabled: strconv.ParseBool: parsing "notaboolean": invalid syntax"
        	Test:       	TestParseClientProvidedSessionParameters/crdb:jwt_auth_enabled_must_be_a_boolean_if_provided
    --- FAIL: TestParseClientProvidedSessionParameters/crdb:jwt_auth_enabled_must_be_a_boolean_if_provided (0.00s)
=== RUN   TestParseClientProvidedSessionParameters/normalize_to_lower_case_in_options_parameter
    conn_test.go:1547: 
        	Error Trace:	/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/2281/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/pgwire_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/pgwire/conn_test.go:1547
        	            				/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/2281/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/pgwire_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/pgwire/conn_test.go:1584
        	Error:      	Received unexpected error:
        	            	unexpected protocol version: 80877102
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/sql/pgwire.getSessionArgs
        	            	  | 	github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:567
        	            	  | github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestParseClientProvidedSessionParameters.func26
        	            	  | 	github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:1583
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1446
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1594
        	            	Wraps: (2) unexpected protocol version: 80877102
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestParseClientProvidedSessionParameters/normalize_to_lower_case_in_options_parameter
    --- FAIL: TestParseClientProvidedSessionParameters/normalize_to_lower_case_in_options_parameter (0.00s)

Parameters: TAGS=bazel,gss,race

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-experience @cockroachdb/server

This test on roachdash | Improve this report!

Jira issue: CRDB-22395
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Dec 13, 2022
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Dec 13, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Dec 13, 2022
@knz
Copy link
Contributor

knz commented Dec 13, 2022

cc @rafiss this one surprises me. I am not sure how it's possible.

@knz knz mentioned this issue Dec 13, 2022
Merged
@knz
Copy link
Contributor

knz commented Dec 13, 2022

Maybe related: #93469

@andreimatei
Copy link
Contributor

Yeah, let's take it to #93469.

@craig craig bot closed this as completed in 1ee3989 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

sql/pgwire: skip TestParseClientProvidedSessionParameters renatolabs/cockroach
3 participants
@andreimatei @knz @cockroach-teamcity