Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: ui: change height of column selector #91910

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Nov 15, 2022

Backport 1/1 commits from #91867.

/cc @cockroachdb/release


Previosuly, it was hard to identify there was more items on the columns selector, since the scrollbar is confugured by the user and might not show up right away (it will show once you hover with mouse and scroll).
This commit changes the height of the filter, making part of the next options to show up, hinting there is more options when scrolling.

Part Of #91763

Before
Screen Shot 2022-11-14 at 2 59 39 PM

After
Screen Shot 2022-11-14 at 3 02 47 PM

Release note (ui change): Change the height of column selector, so it can hint there are more options to be selected once scrolled.


Release justification: small ui fix

Previosuly, it was hard to identify there was more
items on the columns selector, since the scrollbar is confugured
by the user and might not show up right away (it will show once
you hover with mouse and scroll).
This commit changes the height of the filter, making part of
the next options to show up, hinting there is more options
when scrolling.

Part Of cockroachdb#91763

Release note (ui change): Change the height of column selector,
so it can hint there are more options to be selected once
scrolled.
@maryliag maryliag requested a review from a team November 15, 2022 14:50
@blathers-crl
Copy link

blathers-crl bot commented Nov 15, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag merged commit 7c4b28f into cockroachdb:release-22.1 Nov 15, 2022
@maryliag maryliag deleted the backport22.1-91867 branch November 15, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants