Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: change height of column selector #91867

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Nov 14, 2022

Previosuly, it was hard to identify there was more items on the columns selector, since the scrollbar is confugured by the user and might not show up right away (it will show once you hover with mouse and scroll).
This commit changes the height of the filter, making part of the next options to show up, hinting there is more options when scrolling.

Part Of #91763

Before
Screen Shot 2022-11-14 at 2 59 39 PM

After
Screen Shot 2022-11-14 at 3 02 47 PM

Release note (ui change): Change the height of column selector, so it can hint there are more options to be selected once scrolled.

@maryliag maryliag requested review from dongniwang and a team November 14, 2022 20:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previosuly, it was hard to identify there was more
items on the columns selector, since the scrollbar is confugured
by the user and might not show up right away (it will show once
you hover with mouse and scroll).
This commit changes the height of the filter, making part of
the next options to show up, hinting there is more options
when scrolling.

Part Of cockroachdb#91763

Release note (ui change): Change the height of column selector,
so it can hint there are more options to be selected once
scrolled.
Copy link
Member

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @dongniwang)

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 15, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 15, 2022

Build succeeded:

@craig craig bot merged commit 47c7b3a into cockroachdb:master Nov 15, 2022
@blathers-crl
Copy link

blathers-crl bot commented Nov 15, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from fe2f0af to blathers/backport-release-22.1-91867: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 403 Resource not accessible by integration []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


error creating merge commit from fe2f0af to blathers/backport-release-22.2-91867: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 403 Resource not accessible by integration []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants