-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrades: fix idempotence issue in system table role id migrations #91756
Conversation
Depends on #91755 |
1f8c95f
to
389303f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
make sure to backport this to 22.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @andyyang890)
This patch fixes an idempotence issue in the role id migrations for the system.users and system.role_options tables. Release note: None
389303f
to
b8ca64f
Compare
bors r=ajwerner,rafiss |
91756: upgrades: fix idempotence issue in system table role id migrations r=ajwerner,rafiss a=andyyang890 This patch fixes an idempotence issue in the role id migrations for the system.users and system.role_options tables. Fixes #91449 Release note: None Co-authored-by: Andy Yang <[email protected]>
Build failed: |
test flakes bors r=ajwerner,rafiss |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from b8ca64f to blathers/backport-release-22.2-91756: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 403 Resource not accessible by integration [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This patch fixes an idempotence issue in the role id migrations for
the system.users and system.role_options tables.
Fixes #91449
Release note: None