-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrades: add weaker column schema exists funcs for use with migrations #91755
Conversation
0b064a1
to
c9e894a
Compare
This patch adds two schema exists functions for use with migrations that involve multiple schema changes on the same column(s) in order to preserve the idempotence of the migration(s). They are weaker in the sense that they do not check that the stored and final expected descriptor match. Release note: None
c9e894a
to
61cc346
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @andyyang890 and @rafiss)
pkg/upgrade/upgrades/schema_changes.go
line 245 at r1 (raw file):
storedTable, expectedTable catalog.TableDescriptor, colName string, ) (bool, error) { _, err := storedTable.FindColumnWithName(tree.Name(colName))
This lead to my filing #91924, but don't do anything about it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @andyyang890)
TFTRs! bors r=ajwerner,rafiss |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 61cc346 to blathers/backport-release-22.2-91755: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 403 Resource not accessible by integration [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This patch adds two schema exists functions for use with migrations
that involve multiple schema changes on the same column(s) in order
to preserve the idempotence of the migration(s). They are weaker
in the sense that they do not check that the stored and final
expected descriptor match.
Informs #91449
Release note: None