ui: handle errors on db endpoints #90862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
force-pushed
the
db-timeout
branch
3 times, most recently
from
f4a7bbd to
2e7cb94
Compare
Previously, when hitting an error on endpoints used on the database page, we would just keep retrying constantly, without showing a proper error state. On SQL Activity page, for example, we show the error message and let the user retry if they want. This commit uses the same logic on the Database page. Since the pages make several requests and just part of them can fail, some of the pages we will still load, but give a warning about unavailable data and show the error message about reload option. This commit also increases timeout of database endpoints. Fixes cockroachdb#90596 Release note: None
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 35caa9e to blathers/backport-release-22.1-90862: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. error creating merge commit from 35caa9e to blathers/backport-release-22.2-90862: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This was referenced Oct 31, 2022
|
Hey @maryliag 👋 It looks like this change broke CI's Do you mind taking a look? |
maryliag
added a commit
to maryliag/cockroach
that referenced
this pull request
Nov 1, 2022
The PR cockroachdb#90862 introduced an error on generated code. This PR fixes the missing parameters used for tests. Epic: None Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this pull request
Nov 1, 2022
The PR cockroachdb#90862 introduced an error on generated code. This PR fixes the missing parameters used for tests. Epic: None Release note: None
craig bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
89778: schemachanger: Enable adding/dropping path of check constraints r=Xiang-Gu a=Xiang-Gu See each commit message for deatils. Commit 1 (easy to review): Fixed a careless bug in existing code; Commit 2 (easy to review): Added a bool field, `FromHashShardedIndex`, in the protobuf definition of the `CheckConstraint` element. Commit 3 (meaty commit): Enable adding/dropping path of check constraints. ``` ABSENT <==> WRITE_ONLY <==> VALIDATED <==> PUBLIC ``` Informs #89665 90956: builtins: add timestamp to crdb_internal.scan/list_sql_keys_in_range r=stevendanna a=adityamaru This change adds a third return column to the builtins that corresponds to the timestamp at which the value for a particular key was written. Release note (sql change): `crdb_internal.scan` and `crdb_internal.list_sql_keys_in_range` return the timestamp at which the value for a key was written, in addition to the raw key and value. 91024: backupccl: ensure restore2TB/nodes=10/with-pause pauses at least once r=msbutler a=msbutler This patch adds a check that will cause the roachtest to fail if the job was not paused at least once. Release note: None Epic: none 91055: test: fix error on test r=maryliag a=maryliag The PR #90862 introduced an error on generated code. This PR fixes the missing parameters used for tests. Epic: None Release note: None 91061: bazci: fix issue posting r=nicktrav a=rickystewart This block got accidentally deleted in `61161542c910d82c86e4c8ccb6fd2946bba9ab8d`. Release note: None Epic: None Co-authored-by: Xiang Gu <[email protected]> Co-authored-by: adityamaru <[email protected]> Co-authored-by: Michael Butler <[email protected]> Co-authored-by: maryliag <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when hitting an error on endpoints
used on the database page, we would just keep retrying constantly, without showing a proper error state.
On SQL Activity page, for example, we show the error message and let the user retry if they want.
This commit uses the same logic on the Database page. Since the pages make several requests and just part of them can fail, some of the pages we will still load, but give a warning about unavailable data and show the error message about reload option.
This commit also increases timeout of database endpoints.
Fixes #90596
https://www.loom.com/share/edc46386a6fe408b90fa5b6330870819
Release note: None