Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-ui: support large response sizes for sql-over-http endpoints #93065

Closed
THardy98 opened this issue Dec 5, 2022 · 3 comments
Closed

cluster-ui: support large response sizes for sql-over-http endpoints #93065

THardy98 opened this issue Dec 5, 2022 · 3 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@THardy98
Copy link

THardy98 commented Dec 5, 2022

Is your feature request related to a problem? Please describe.
Currently, the sql-over-http endpoint provides a modifiable request parameter max_result_size to configure the size of the response sent back from the server (the default value being 10KiB). Responses that exceed the configured limit will return the maximum number of result rows that can fit within the limit, as well as an error (indicating that the query results exceed the limit).

Currently, we do not have a good way of handling endpoints that can return data sizes larger than the configured limit. The current remedy for this issue is to simply increase the limit for the endpoint, which is not scalable.

As a solution, we could add pagination logic to queries used in our endpoints, rectifying the need to continually up the response limit and load the complete (potentially large) result set in browser memory.

Additionally, there are a number of sql-over-http endpoints that do not support loading of partial results when encountering an error due to large result size. We would like to add logic to allow for rendering of partial results, as has already been done in:
#90862

Jira issue: CRDB-22141
Epic: CRDB-20388

@THardy98 THardy98 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability labels Dec 5, 2022
@THardy98
Copy link
Author

Relevant: #75510

@kevin-v-ngo
Copy link

Up next to align with the following issue #75510

@maryliag
Copy link
Contributor

maryliag commented Nov 3, 2023

No longer a priority

@maryliag maryliag closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

3 participants