Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: add a virtual index on database name for SHOW GRANTS ON DATABASE #90712

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 26, 2022

Backport 1/1 commits from #90597 on behalf of @ajwerner.

/cc @cockroachdb/release


Before this change, we'd always fetch all databases. This is expensive if there are many. It's also the case that the databases page will run this for each database. In that case, this was an N^2 proposition.

Epic: CRDB-20865

Release note (performance improvement): SHOW GRANTS ON DATABASE and the Databases page in the cluster UI are now faster if there are many databases.


Release justification: Simple improvement for UI behavior

Before this change, we'd always fetch all databases. This is expensive if there
are many. It's also the case that the databases page will run this for each
database. In that case, this was an N^2 proposition.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team October 26, 2022 17:08
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-90597 branch from 10b9e75 to bd52adc Compare October 26, 2022 17:08
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 26, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from postamar and rafiss October 26, 2022 17:08
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 26, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator

rafiss commented Oct 26, 2022

is this related to #90196 ?

@ajwerner
Copy link
Contributor

is this related to #90196 ?

Yes. We collect the grants of the database here. In my local cluster I had 10k databases. The request would always time out because SHOW GRANTS ON DATABASE was taking 35s. I also filed #90596. After this patch, SHOW GRANTS ON DATABASE is plenty fast. SHOW GRANTS ON TABLE is still horrific. It's harder to fix but I'd like to do something.

@ajwerner ajwerner merged commit c48e23a into release-22.2 Oct 26, 2022
@ajwerner ajwerner deleted the blathers/backport-release-22.2-90597 branch October 26, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants