sql: add a virtual index on database name for SHOW GRANTS ON DATABASE #90597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/improve-show-grants-for-database
branch
3 times, most recently
from
cdab66c to
8fb3e08
Compare
Before this change, we'd always fetch all databases. This is expensive if there are many. It's also the case that the databases page will run this for each database. In that case, this was an N^2 proposition. Release note: None
ajwerner
force-pushed
the
ajwerner/improve-show-grants-for-database
branch
from
8fb3e08 to
02cc484
Compare
postamar
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
rafiss
approved these changes
Oct 26, 2022
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we'd always fetch all databases. This is expensive if there are many. It's also the case that the databases page will run this for each database. In that case, this was an N^2 proposition.
Epic: CRDB-20865
Release note: None