Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2.0: clusterversion: mint 22.2 #90281

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

celiala
Copy link
Collaborator

@celiala celiala commented Oct 19, 2022

Backport 1/3 commits from #90066.

/cc @cockroachdb/release


See commits.

Epic: none.
Release justification: Non-production, infra-only change.

Release note: none.
@blathers-crl
Copy link

blathers-crl bot commented Oct 19, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@celiala celiala changed the title release-22.2.x: clusterversion: mint 22.2 release-22.2.0: clusterversion: mint 22.2 Oct 19, 2022
@celiala celiala added the do-not-merge bors won't merge a PR with this label. label Oct 19, 2022
@celiala
Copy link
Collaborator Author

celiala commented Oct 19, 2022

Adding do-not-merge label to denote that this should be the very last commit merged onto release-22.2.0 before RC candidate selection.

@celiala celiala marked this pull request as ready for review October 19, 2022 19:53
@celiala celiala requested review from dt and jlinder October 31, 2022 15:32
@celiala celiala removed the do-not-merge bors won't merge a PR with this label. label Nov 1, 2022
@celiala
Copy link
Collaborator Author

celiala commented Nov 1, 2022

Confirmed with Storage/SQL that need for version gates for outstanding blockers are very unlikely. Merging.

@celiala celiala merged commit aaf671b into cockroachdb:release-22.2.0 Nov 1, 2022
@celiala celiala deleted the backport22.2.0-90066 branch November 1, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants