Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clusterversion: define 22.2 and 23.1 start #90066

Merged
merged 3 commits into from
Oct 17, 2022
Merged

clusterversion: define 22.2 and 23.1 start #90066

merged 3 commits into from
Oct 17, 2022

Conversation

dt
Copy link
Member

@dt dt commented Oct 17, 2022 •
edited
Loading

See commits.

Epic: none.

@dt dt requested review from knz, ajwerner and celiala October 17, 2022 15:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

knz
knz approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

dt added 3 commits October 17, 2022 16:33
@dt
clusterversion: mint 22.2
2e01a1a 
Release note: none.
@dt
clusterverion: start 23.1 dev versions
e8fcd99 
Release note: none.
Epic: none.
@dt
clusterversion: define 23.1 placeholder key
c2e366e 
Release note: none.
Epic: none.
celiala
celiala approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)

@dt
Copy link
Member Author

dt commented Oct 17, 2022

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 17, 2022

Build succeeded:

@craig craig bot merged commit 98b1e0c into cockroachdb:master Oct 17, 2022
@dt dt deleted the 22.2-mint branch October 17, 2022 19:09
This was referenced Oct 19, 2022
Merged
Merged
@dt dt mentioned this pull request Nov 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celiala celiala celiala approved these changes

@knz knz knz approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dt @cockroach-teamcity @knz @celiala