sql: fix a non-deterministic DELETE ... USING logic test #90251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rytaft
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @faizaanmadhani and @mgartner)
-- commits line 14 at r1:
If the linter complains, you might need to write this as "Epic: CRDB-5498"
faizaanmadhani
force-pushed
the
faizaan/delete-from-using-hotfix
branch
from
c63273e to
4bc3617
Compare
Previously, rytaft (Rebecca Taft) wrote…
Oh I see you already changed it in the PR message -- feel free to ignore! |
mgartner
approved these changes
Oct 19, 2022
Previously, a logic test testing ORDER BY and LIMIT in DELETE ... USING statements would sometimes return a different row from the USING table when run through stress tests, due to the ORDER BY ... LIMIT clause allowing the USING to join on either of two rows. This fix changes the output columns of the RETURNING to ensure it only returns columns from the target table and ensures deterministic output. Release note: None Epic: CRDB-5498
faizaanmadhani
force-pushed
the
faizaan/delete-from-using-hotfix
branch
from
4bc3617 to
1404540
Compare
|
TFTRs! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a logic test testing ORDER BY and LIMIT in DELETE ... USING statements would sometimes return a different row from the USING table when run through stress tests, due to the ORDER BY ... LIMIT clause allowing the USING to join on either of two rows. This fix changes the output columns of the RETURNING to ensure it only returns columns from the target table and ensures deterministic output.
Release note: None
Epic: CRDB-5498