Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logictest: delete flaked #90242

Closed
msbutler opened this issue Oct 19, 2022 · 5 comments
Closed

logictest: delete flaked #90242

msbutler opened this issue Oct 19, 2022 · 5 comments
Assignees
@faizaanmadhani
Labels
C-test-failure Broken test (automatically or manually discovered). T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@msbutler
Copy link
Collaborator

msbutler commented Oct 19, 2022 •
edited by cockroach-jira-scripts
Loading

See CI failure here

Jira issue: CRDB-20647
@msbutler msbutler added C-test-failure Broken test (automatically or manually discovered). T-sql-schema-deprecated Use T-sql-foundations instead labels Oct 19, 2022
@knz
Copy link
Contributor

knz commented Oct 19, 2022

Another one: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests/7026461?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

@ajwerner ajwerner changed the title sql-schema: TestLogic_delete/regression_33361 flaked logictest: TestLogic_delete/regression_33361 flaked Oct 19, 2022
@ajwerner ajwerner changed the title logictest: TestLogic_delete/regression_33361 flaked logictest: delete flaked Oct 19, 2022
@ajwerner
Copy link
Contributor

#88974 this PR introduced that directive. @faizaanmadhani can you deflake this and also add subtest directive for your newly added tests?

@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Oct 19, 2022
@faizaanmadhani
Copy link
Contributor

Hey @ajwerner, I opened #90251 earlier today that fixed this flaky test, and it merged a few minutes ago

@ajwerner
Copy link
Contributor

@faizaanmadhani cool, I'll close this. Still, can you add a subtest directive in a one-line PR for your new subtest?

@exalate-issue-sync exalate-issue-sync bot removed the T-sql-queries SQL Queries Team label Oct 19, 2022
@faizaanmadhani
Copy link
Contributor

@faizaanmadhani cool, I'll close this. Still, can you add a subtest directive in a one-line PR for your new subtest?

Yup! I've opened the PR here: #90280

@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faizaanmadhani faizaanmadhani

Labels
C-test-failure Broken test (automatically or manually discovered). T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@knz @ajwerner @faizaanmadhani @msbutler