-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: sql,tree: improve function resolution efficiency #89353
Conversation
We don't need pointers for these names. They generally won't escape. Release note: None
The closure-oriented interface was forcing the closures and the variables they referenced to escape to the heap. This change, while not beautiful, ends up being much more efficient. Release note: None
17ce30a
to
6afaf70
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Should this go in 22.2.0 too?
Reviewed 6 of 6 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan)
Is it a GA blocker? |
I guess not. |
Backport 2/2 commits from #89317 on behalf of @ajwerner.
/cc @cockroachdb/release
sql: prevent allocations by avoiding some name pointers
We don't need pointers for these names. They generally won't escape.
sql,tree: change SearchPath to avoid allocations
The closure-oriented interface was forcing the closures and the variables they
referenced to escape to the heap. This change, while not beautiful, ends up being
much more efficient.
Release note: None
Release justification: nice win for very little cost