-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql,tree: improve function resolution efficiency #89317
Merged
craig
merged 2 commits into
cockroachdb:master
from
ajwerner:ajwerner/tune-resolve-function
Oct 4, 2022
Merged
sql,tree: improve function resolution efficiency #89317
craig
merged 2 commits into
cockroachdb:master
from
ajwerner:ajwerner/tune-resolve-function
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #85391 (comment) |
ajwerner
force-pushed
the
ajwerner/tune-resolve-function
branch
from
October 4, 2022 19:03
befd56f
to
0cc2d41
Compare
chengxiong-ruan
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained
We don't need pointers for these names. They generally won't escape. Release note: None
The closure-oriented interface was forcing the closures and the variables they referenced to escape to the heap. This change, while not beautiful, ends up being much more efficient. Release note: None
ajwerner
force-pushed
the
ajwerner/tune-resolve-function
branch
from
October 4, 2022 19:24
0cc2d41
to
e99a182
Compare
TFTR! bors r+ |
Build failed: |
bors r+ |
Build succeeded: |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: prevent allocations by avoiding some name pointers
We don't need pointers for these names. They generally won't escape.
sql,tree: change SearchPath to avoid allocations
The closure-oriented interface was forcing the closures and the variables they
referenced to escape to the heap. This change, while not beautiful, ends up being
much more efficient.
Release note: None