Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scpb: remove IsRelationBeingDropped fields #89086

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

postamar
Copy link
Contributor

These have been rendered obsolete by the addition of not-join clauses in the rules.

Fixes #89002.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar marked this pull request as ready for review September 30, 2022 16:07
@postamar postamar requested a review from a team September 30, 2022 16:07
Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some generated file to fix. Otherwise :lgtm:

Reviewed 2 of 17 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

These have been rendered obsolete by the addition of not-join clauses in
the rules.

Fixes cockroachdb#89002.

Release note: None
@postamar
Copy link
Contributor Author

postamar commented Oct 1, 2022

Thanks for the reviews!

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 1, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scpb: remove IsRelationBeingDropped fields
4 participants