Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scpb: remove IsRelationBeingDropped fields #89002

Closed
postamar opened this issue Sep 29, 2022 · 0 comments · Fixed by #89086
Closed

scpb: remove IsRelationBeingDropped fields #89002

postamar opened this issue Sep 29, 2022 · 0 comments · Fixed by #89086
Labels
A-schema-changer-impl Related to the implementation of the new schema changer branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@postamar
Copy link
Contributor

postamar commented Sep 29, 2022 •
edited by cockroach-jira-scripts
Loading

These IsRelationBeingDropped fields in the ColumnType and SecondaryIndexPartial elements are no longer necessary now that we can do not-joins. We can remove them outright instead of deprecating them because the declarative schema changer in 22.1 only did DROPs of descriptor-elements so these never came into play.

Jira issue: CRDB-20074
@postamar postamar added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 labels Sep 29, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Sep 29, 2022
@postamar postamar added the A-schema-changer-impl Related to the implementation of the new schema changer label Sep 29, 2022
@postamar postamar mentioned this issue Sep 30, 2022
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Sep 30, 2022
scpb: remove IsRelationBeingDropped fields
6c02369 
These have been rendered obsolete by the addition of not-join clauses in
the rules.

Fixes cockroachdb#89002.

Release note: None
craig bot pushed a commit that referenced this issue Oct 1, 2022
Merge #89086
93042a1 
89086: scpb: remove IsRelationBeingDropped fields r=postamar a=postamar

These have been rendered obsolete by the addition of not-join clauses in the rules.

Fixes #89002.

Release note: None

Co-authored-by: Marius Posta <[email protected]>
@craig craig bot closed this as completed in 06677c2 Oct 1, 2022
@blathers-crl blathers-crl bot mentioned this issue Oct 1, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Oct 1, 2022
scpb: remove IsRelationBeingDropped fields
b100616 
These have been rendered obsolete by the addition of not-join clauses in
the rules.

Fixes #89002.

Release note: None
postamar pushed a commit that referenced this issue Oct 3, 2022
scpb: remove IsRelationBeingDropped fields
1397baa 
These have been rendered obsolete by the addition of not-join clauses in
the rules.

Fixes #89002.

Release note: None
@exalate-issue-sync exalate-issue-sync bot reopened this May 10, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
@rafiss rafiss closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-schema-changer-impl Related to the implementation of the new schema changer branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scpb: remove IsRelationBeingDropped fields postamar/cockroach
2 participants
@rafiss @postamar