Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: use n1-standard for 16-core GCE machines #88346

Merged
merged 1 commit into from
Sep 22, 2022
Merged

roachtest: use n1-standard for 16-core GCE machines #88346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/spec/machine_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ func AWSMachineType(cpus int) string {

// GCEMachineType selects a machine type given the desired number of CPUs.
func GCEMachineType(cpus int) string {
// TODO(peter): This is awkward: below 16 cpus, use n1-standard so that the
// machines have a decent amount of RAM. We could use customer machine
// TODO(peter): This is awkward: at or below 16 cpus, use n1-standard so that
// the machines have a decent amount of RAM. We could use custom machine
// configurations, but the rules for the amount of RAM per CPU need to be
// determined (you can't request any arbitrary amount of RAM).
if cpus < 16 {
if cpus <= 16 {
return fmt.Sprintf("n1-standard-%d", cpus)
}
return fmt.Sprintf("n1-highcpu-%d", cpus)
Expand Down